View Issue Details
|ID||Project||Category||View Status||Date Submitted||Last Update|
|0005695||Simple:Press||code - classes||public||2016-12-25 18:08||2017-07-11 01:58|
|Reporter||Mr Papa||Assigned To||Mr Papa|
|Priority||normal||Severity||N/A||Reproducibility||have not tried|
|Target Version||5.8||Fixed in Version||5.8|
|Summary||0005695: do class files need the "cannot call directly" check|
|Description||some of our class files have it, some do not... should be consistent.|
my gut says they are not needed for class files, but we should answer and make all same...
|Tags||No tags attached.|
|change_log_text||remove special checks for class files being called directly since nothing but class in there|
any thought on this one?
looked at bunch of other wp plugins (including EDD and RCP) and most do not... unless their is code outside the class, ie the instantiation...
not sure much could be done by calling a file with everything in class... my gut says we could get rid of...
|Sounds right to me. So sure - let's remove them|
Changeset  by steve on 2017-01-02 18:03:22 -0500 (Mon, 02 Jan 2017)
test issue 0005695 lets not put special checks for class files being called directly since nothing but class in there
|2016-12-25 18:08||Mr Papa||New Issue|
|2016-12-31 01:29||Mr Papa||Note Added: 0018969|
|2016-12-31 09:45||Yellow Swordfish||Note Added: 0018974|
|2017-01-02 22:44||Mr Papa||Assigned To||=> Mr Papa|
|2017-01-02 22:44||Mr Papa||Status||new => assigned|
|2017-01-02 23:03||svn||Note Added: 0018991|
|2017-01-02 23:03||svn||Status||assigned => testing|
|2017-01-07 20:31||Mr Papa||Status||testing => closed|
|2017-01-07 20:31||Mr Papa||Resolution||open => fixed|
|2017-01-07 20:31||Mr Papa||Fixed in Version||=> 6.0|
|2017-01-07 20:31||Mr Papa||change_log_text||update => remove special checks for class files being called directly since nothing but class in there|
|2017-07-11 01:58||Mr Papa||Fixed in Version||6.0 => 5.8|
|2017-07-11 01:58||Mr Papa||Target Version||6.0 => 5.8|