View Issue Details

IDProjectCategoryView StatusLast Update
0005732Simple:Presscode - generalpublic2017-07-11 01:58
ReporterMr PapaAssigned ToMr Papa 
PrioritynormalSeverityN/AReproducibilityhave not tried
Status closedResolutionfixed 
Product Version5.7.3 
Target Version5.8Fixed in Version5.8 
Summary0005732: clean up global variable usage
Descriptionstill have few global variables we should clean up... like $spThisUser, $spProfileUser, $spSearchView, etc...

should belong to a class...
TagsNo tags attached.
change_log_text clean up global variable usage
typedefect

Activities

svn

svn

2017-01-27 16:21

administrator   ~0019116

Changeset [15105] by steve on 2017-01-27 11:21:13 -0500 (Fri, 27 Jan 2017)

see issue 0005732 move $spThisUser into user class and get rid of global

 Changed Files:

U plugins/admin-bar/admin/sp-admin-bar-options.php
U plugins/admin-bar/ajax/sp-admin-bar-ajax-links.php
U plugins/admin-bar/ajax/sp-admin-bar-ajax-moderation.php
U plugins/admin-bar/ajax/sp-admin-bar-ajax-newposts.php
U plugins/admin-bar/ajax/sp-admin-bar-ajax-quickreply.php
U plugins/admin-bar/ajax/sp-admin-bar-ajax-spam.php
U plugins/admin-bar/ajax/sp-admin-bar-ajax-update.php
U plugins/admin-bar/library/sp-admin-bar-components.php
U plugins/admin-bar/library/sp-akismet.php
U plugins/admin-bar/sp-admin-bar-install.php
U plugins/admin-bar/template-tags/sp-admin-bar-links-tag.php
U plugins/admin-bar/template-tags/sp-admin-bar-queue-tag.php
U plugins/anonymous/library/sp-anonymous-components.php
U plugins/answers-topic/library/sp-answers-topic-components.php
U plugins/answers-topic/library/sp-answers-topic-mycred.php
U plugins/answers-topic/template-tags/sp-answers-topic-answers-button.php
U plugins/ban/ajax/sp-ban-ajax-manage.php
U plugins/ban/library/sp-ban-components.php
U plugins/blog-linking/ajax/sp-ajax-categories.php
U plugins/blog-linking/library/sp-linking-blog.php
U plugins/blog-linking/library/sp-linking-comments.php
U plugins/buddypress/library/sp-buddypress-activity.php
U plugins/buddypress/library/sp-buddypress-component.php
U plugins/buddypress/library/sp-buddypress-notifications.php
U plugins/buddypress/library/sp-buddypress-screens.php
U plugins/cubepoints/template-tags/sp-cubepoints-points.php
U plugins/custom-profile-fields/library/sp-custom-profile-fields-components.php
U plugins/custom-profile-fields/template-tags/sp-custom-profile-fields-display-tag.php
U plugins/featured/library/sp-featured-components.php
U plugins/hide-poster/library/sp-hide-poster-components.php
U plugins/html-email/sp-html-email-install.php
U plugins/logger/sp-logger-install.php
U plugins/mentions/library/sp-mentions-components.php
U plugins/mentions/template-tags/sp-mentions-your-latest-mentions-tag.php
U plugins/mycred/template-tags/sp-mycred-points.php
U plugins/online/template-tags/sp-online-activity-tag.php
U plugins/online/template-tags/sp-online-currently-tag.php
U plugins/plupload/ajax/sp-plupload-ajax-manage.php
U plugins/plupload/library/sp-plupload-components.php
U plugins/plupload/library/sp-plupload-forms.php
U plugins/plupload/library/sp-plupload-remove.php
U plugins/plupload/library/sp-plupload-upload.php
U plugins/plupload/sp-plupload-upgrade.php
U plugins/polls/ajax/sp-polls-ajax-edit.php
U plugins/polls/ajax/sp-polls-ajax-log.php
U plugins/polls/ajax/sp-polls-ajax-manage.php
U plugins/polls/library/sp-polls-components.php
U plugins/polls/library/sp-polls-mycred.php
U plugins/polls/sp-polls-install.php
U plugins/post-as/ajax/sp-post-as-ajax-manage.php
U plugins/post-as/library/sp-post-as-components.php
U plugins/post-multiple/library/sp-post-multiple-components.php
U plugins/post-rating/ajax/sp-rating-ajax-manage.php
U plugins/post-rating/library/sp-rating-database.php
U plugins/post-rating/library/sp-rating-mycred.php
U plugins/post-rating/template-tags/sp-highest-rated-tag.php
U plugins/post-rating/template-tags/sp-most-rated-tag.php
U plugins/post-rating/template-tags/sp-rating-post-rating.php
U plugins/post-rating/template-tags/sp-rating-topic-rating.php
U plugins/post-thanks/ajax/sp-thanks-ajax.php
U plugins/post-thanks/library/sp-thanks-components.php
U plugins/post-thanks/library/sp-thanks-mycred.php
U plugins/post-thanks/template-tags/sp-thanks-thank-the-post.php
U plugins/post-thanks/template-tags/sp-thanks-user-stats.php
U plugins/private-messaging/ajax/sp-pm-ajax-manage.php
U plugins/private-messaging/ajax/sp-pm-ajax-post.php
U plugins/private-messaging/forms/sp-pm-compose-form.php
U plugins/private-messaging/library/sp-pm-components.php
U plugins/private-messaging/library/sp-pm-database.php
U plugins/private-messaging/library/sp-pm-messages-class.php
U plugins/private-messaging/library/sp-pm-template-functions.php
U plugins/private-messaging/library/sp-pm-threads-class.php
U plugins/private-messaging/sp-pm-install.php
U plugins/private-messaging/sp-pm-plugin.php
U plugins/private-messaging/template-files/spPMMessagesView.php
U plugins/private-messaging/template-tags/sp-pm-inbox-button-tag.php
U plugins/private-messaging/template-tags/sp-pm-inbox-tag.php
U plugins/private-messaging/template-tags/sp-pm-profile-send-pm-tag.php
U plugins/private-messaging/template-tags/sp-pm-send-pm-button-tag.php
U plugins/private-messaging/template-tags/sp-pm-send-tag.php
U plugins/private-messaging/template-tags/sp-pm-sidedash-tag.php
U plugins/private-posts/library/sp-private-posts-components.php
U plugins/rank-info/library/sp-rank-info-components.php
U plugins/report-post/library/sp-report-post-components.php
U plugins/report-post/template-tags/sp-report-post-tag.php
U plugins/reputation/ajax/sp-reputation-ajax-manage.php
U plugins/reputation/library/sp-reputation-components.php
U plugins/reputation/sp-reputation-install.php
U plugins/reputation/template-tags/sp-reputation-members-list-level.php
U plugins/reputation/template-tags/sp-reputation-most-reputable.php
U plugins/reputation/template-tags/sp-reputation-rep-user.php
U plugins/search-by-user/ajax/sp-search-by-user-ajax-manage.php
U plugins/subscriptions/ajax/sp-subscriptions-ajax-manage.php
U plugins/subscriptions/library/sp-subscriptions-components.php
U plugins/subscriptions/library/sp-subscriptions-database.php
U plugins/subscriptions/template-files/spSubscriptionsView.php
U plugins/subscriptions/template-tags/sp-subscriptions-forum-index-icon-tag.php
U plugins/subscriptions/template-tags/sp-subscriptions-review-button-tag.php
U plugins/subscriptions/template-tags/sp-subscriptions-subscribe-button-tag.php
U plugins/subscriptions/template-tags/sp-subscriptions-subscribe-forum-button-tag.php
U plugins/subscriptions/template-tags/sp-subscriptions-topics-tags.php
U plugins/tags/ajax/sp-tags-ajax.php
U plugins/tags/library/sp-tags-database.php
U plugins/tags/sp-tags-install.php
U plugins/template-tags/library/sp-ForumDropdown-tag.php
U plugins/template-tags/library/sp-HotTopics-tag.php
U plugins/template-tags/library/sp-ProfileLink-tag.php
U plugins/template-tags/library/sp-SideDash-tag.php
U plugins/template-tags/sp-template-tags-plugin.php
U plugins/threading/ajax/sp-threading-ajax-move.php
U plugins/threading/sp-threading-plugin.php
U plugins/threading/template-tags/sp-threading-tags.php
U plugins/uploads-viewer/ajax/sp-uploads-viewer-ajax-view.php
U plugins/uploads-viewer/library/sp-uploads-viewer-components.php
U plugins/warnings-suspensions/library/sp-warnings-suspensions-components.php
U plugins/warnings-suspensions/sp-warnings-suspensions-install.php
U plugins/watches/ajax/sp-watches-ajax-manage.php
U plugins/watches/library/sp-watches-components.php
U plugins/watches/library/sp-watches-database.php
U plugins/watches/template-files/spWatchesView.php
U plugins/watches/template-tags/sp-watches-review-button-tag.php
U plugins/watches/template-tags/sp-watches-topics-tag.php
U plugins/watches/template-tags/sp-watches-watch-button-tag.php

 Differences:

 http://websvn.simple-press.com/revision.php?repname=Simple:Press&path=%2F&rev=15105
svn

svn

2017-01-27 16:21

administrator   ~0019117

Changeset [15106] by steve on 2017-01-27 11:21:29 -0500 (Fri, 27 Jan 2017)

see issue 0005732 move $spThisUser into user class and get rid of global

 Changed Files:

U templates/barebones/templates/spNewPostsView.php
U templates/barebones/templates/spPMMessagesView.php
U templates/reboot/templates/spNewPostsView.php
U templates/reboot/templates/spPMMessagesView.php
U templates/sp-reboot/templates/desktop/spGroupViewDesktop.php
U templates/sp-reboot/templates/mobile/spGroupViewMobile.php
U templates/unified/templates/spFoot.php
U templates/unified/templates/spNewPostsView.php

 Differences:

 http://websvn.simple-press.com/revision.php?repname=Simple:Press&path=%2F&rev=15106
svn

svn

2017-01-27 16:22

administrator   ~0019118

Changeset [15107] by steve on 2017-01-27 11:22:17 -0500 (Fri, 27 Jan 2017)

see issue 0005732 move $spThisUser into user class and get rid of global

 Changed Files:

U trunk/admin/panel-admins/ajax/spa-ajax-admins-loader.php
U trunk/admin/panel-admins/forms/spa-admins-manage-admins-form.php
U trunk/admin/panel-admins/forms/spa-admins-your-options-form.php
U trunk/admin/panel-admins/spa-admins.php
U trunk/admin/panel-admins/support/spa-admins-prepare.php
U trunk/admin/panel-admins/support/spa-admins-save.php
U trunk/admin/panel-toolbox/support/spa-toolbox-prepare.php
U trunk/admin/panel-toolbox/support/spa-toolbox-save.php
U trunk/forum/content/ajax/sp-ajax-admintoollinks.php
U trunk/forum/content/ajax/sp-ajax-admintools.php
U trunk/forum/content/ajax/sp-ajax-newpostpopup.php
U trunk/forum/content/ajax/sp-ajax-quote.php
U trunk/forum/content/classes/sp-view-class-spcforumview.php
U trunk/forum/content/classes/sp-view-class-spcgroupview.php
U trunk/forum/content/classes/sp-view-class-spcmemberslist.php
U trunk/forum/content/classes/sp-view-class-spcpostlist.php
U trunk/forum/content/classes/sp-view-class-spcsearchview.php
U trunk/forum/content/classes/sp-view-class-spctopiclist.php
U trunk/forum/content/classes/sp-view-class-spctopicview.php
U trunk/forum/content/forms/sp-form-components.php
U trunk/forum/content/forms/sp-form-post.php
U trunk/forum/content/forms/sp-form-search.php
U trunk/forum/content/forms/sp-form-topic.php
U trunk/forum/content/sp-common-control-functions.php
U trunk/forum/content/sp-common-view-functions.php
U trunk/forum/content/sp-forum-view-functions.php
U trunk/forum/content/sp-group-view-functions.php
U trunk/forum/content/sp-profile-view-functions.php
U trunk/forum/content/sp-template-control.php
U trunk/forum/content/sp-topic-view-functions.php
U trunk/forum/database/sp-db-management.php
U trunk/forum/database/sp-db-newposts.php
U trunk/forum/database/sp-db-statistics.php
U trunk/forum/feeds/sp-feeds.php
U trunk/forum/library/sp-post.php
U trunk/forum/profile/ajax/sp-ajax-profile-save.php
U trunk/forum/profile/ajax/sp-ajax-profile.php
U trunk/forum/profile/forms/sp-form-avatar.php
U trunk/forum/profile/forms/sp-form-memberships.php
U trunk/forum/profile/forms/sp-form-profile.php
U trunk/sp-api/sp-api-class-spcauths.php
U trunk/sp-api/sp-api-class-spccache.php
U trunk/sp-api/sp-api-class-spcdatetime.php
U trunk/sp-api/sp-api-class-spcdb.php
U trunk/sp-api/sp-api-class-spcdisplayfilters.php
U trunk/sp-api/sp-api-class-spcnotifications.php
U trunk/sp-api/sp-api-class-spcpermalinks.php
U trunk/sp-api/sp-api-class-spcrewrites.php
U trunk/sp-api/sp-api-class-spcsavefilters.php
U trunk/sp-api/sp-api-class-spcuser.php
U trunk/sp-startup/admin/spa-admin-framework.php
U trunk/sp-startup/admin/spa-admin-menu.php
U trunk/sp-startup/admin/spa-admin-support-functions.php
U trunk/sp-startup/core/credentials/sp-credentials.php
U trunk/sp-startup/core/sp-core-debug.php
U trunk/sp-startup/core/sp-core-support-functions.php
U trunk/sp-startup/forum/sp-forum-framework.php

 Differences:

 http://websvn.simple-press.com/revision.php?repname=Simple:Press&path=%2F&rev=15107
svn

svn

2017-01-27 17:55

administrator   ~0019121

Changeset [15113] by steve on 2017-01-27 12:55:56 -0500 (Fri, 27 Jan 2017)

see issue 0005732 move $spProfileUser into user class and get rid of global

 Changed Files:

U plugins/anonymous/library/sp-anonymous-components.php
U plugins/birthdays/library/sp-birthdays-components.php
U plugins/buddypress/library/sp-buddypress-screens.php
U plugins/custom-profile-fields/library/sp-custom-profile-fields-components.php
U plugins/identities/library/sp-identities-components.php
U plugins/keywords/forms/sp-keywords-options-form.php
U plugins/mentions/library/sp-mentions-components.php
U plugins/post-thanks/template-tags/sp-thanks-profile-reputation.php
U plugins/private-messaging/ajax/sp-pm-ajax-manage.php
U plugins/private-messaging/forms/sp-pm-adversaries-form.php
U plugins/private-messaging/forms/sp-pm-buddies-form.php
U plugins/private-messaging/library/sp-pm-components.php
U plugins/private-messaging/template-tags/sp-pm-profile-send-pm-tag.php
U plugins/subscriptions/ajax/sp-subscriptions-ajax-manage.php
U plugins/subscriptions/forms/sp-subscriptions-forum-form.php
U plugins/subscriptions/forms/sp-subscriptions-manage-form.php
U plugins/subscriptions/forms/sp-subscriptions-options-form.php
U plugins/tinymce-richtext/library/sp-tinymce-init.php
U plugins/tinymce-richtext/sp-tinymce-plugin.php
U plugins/watches/ajax/sp-watches-ajax-manage.php
U plugins/watches/forms/sp-watches-manage-form.php

 Differences:

 http://websvn.simple-press.com/revision.php?repname=Simple:Press&path=%2F&rev=15113
svn

svn

2017-01-27 17:56

administrator   ~0019122

Changeset [15114] by steve on 2017-01-27 12:56:09 -0500 (Fri, 27 Jan 2017)

see issue 0005732 move $spProfileUser into user class and get rid of global

 Changed Files:

U templates/barebones/templates/spProfilePopupShow.php
U templates/barebones/templates/spProfileShow.php
U templates/reboot/templates/spProfilePopupShow.php
U templates/reboot/templates/spProfileShow.php
U templates/unified/templates/spProfilePopupShow.php
U templates/unified/templates/spProfileShow.php

 Differences:

 http://websvn.simple-press.com/revision.php?repname=Simple:Press&path=%2F&rev=15114
svn

svn

2017-01-27 17:56

administrator   ~0019123

Changeset [15115] by steve on 2017-01-27 12:56:39 -0500 (Fri, 27 Jan 2017)

test issue 0005732 move $spProfileUser into user class and get rid of global

 Changed Files:

U trunk/forum/content/sp-profile-view-functions.php
U trunk/forum/content/sp-template-control.php
U trunk/forum/profile/ajax/sp-ajax-profile.php
U trunk/forum/profile/forms/sp-form-account.php
U trunk/forum/profile/forms/sp-form-avatar.php
U trunk/forum/profile/forms/sp-form-display-options.php
U trunk/forum/profile/forms/sp-form-global-options.php
U trunk/forum/profile/forms/sp-form-identities.php
U trunk/forum/profile/forms/sp-form-memberships.php
U trunk/forum/profile/forms/sp-form-overview.php
U trunk/forum/profile/forms/sp-form-photos.php
U trunk/forum/profile/forms/sp-form-posting-options.php
U trunk/forum/profile/forms/sp-form-profile.php
U trunk/forum/profile/forms/sp-form-signature.php
U trunk/sp-api/sp-api-class-spcuser.php
U trunk/sp-startup/forum/sp-forum-support-functions.php

 Differences:

 http://websvn.simple-press.com/revision.php?repname=Simple:Press&path=%2F&rev=15115
svn

svn

2017-01-27 18:43

administrator   ~0019125

Changeset [15117] by steve on 2017-01-27 13:43:52 -0500 (Fri, 27 Jan 2017)

test issue 0005732 clean up some globals

 Changed Files:

U trunk/sp-api/sp-api-class-spcrewrites.php
U trunk/sp-startup/core/sp-core-ajax.php
U trunk/sp-startup/forum/sp-forum-framework.php
U trunk/sp-startup/sp-load-install.php

 Differences:

 http://websvn.simple-press.com/revision.php?repname=Simple:Press&path=%2F&rev=15117

Issue History

Date Modified Username Field Change
2017-01-27 07:19 Mr Papa New Issue
2017-01-27 07:19 Mr Papa Assigned To => Mr Papa
2017-01-27 07:19 Mr Papa Status new => assigned
2017-01-27 16:21 svn =>
2017-01-27 16:21 svn Note Added: 0019116
2017-01-27 16:21 svn =>
2017-01-27 16:21 svn Note Added: 0019117
2017-01-27 16:22 svn =>
2017-01-27 16:22 svn Note Added: 0019118
2017-01-27 17:55 svn =>
2017-01-27 17:55 svn Note Added: 0019121
2017-01-27 17:56 svn =>
2017-01-27 17:56 svn Note Added: 0019122
2017-01-27 17:56 svn =>
2017-01-27 17:56 svn Note Added: 0019123
2017-01-27 17:56 svn Status assigned => testing
2017-01-27 18:43 svn =>
2017-01-27 18:43 svn Note Added: 0019125
2017-02-04 17:25 Mr Papa Status testing => closed
2017-02-04 17:25 Mr Papa Resolution open => fixed
2017-02-04 17:25 Mr Papa Fixed in Version => 6.0
2017-02-04 17:25 Mr Papa change_log_text update => clean up global variable usage
2017-07-11 01:58 Mr Papa Fixed in Version 6.0 => 5.8
2017-07-11 01:58 Mr Papa Target Version 6.0 => 5.8